Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open-scd): Make linear progress bar Github stylez, closes #1269 #1276

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

danyill
Copy link
Collaborator

@danyill danyill commented Jun 24, 2023

Closes #1269

I couldn't find a solution without changing the z-index without more serious DOM modifications.

I have to use --primary I think because I am overwriting --mdc-theme-primary.

I quite like this.

@danyill danyill requested a review from ca-d June 28, 2023 19:00
ca-d
ca-d previously approved these changes Jun 28, 2023
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I especially appreciate the "z" in the pull request title indicating the use of z-index in the css.

src/open-scd.ts Outdated Show resolved Hide resolved
src/open-scd.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@danyill danyill merged commit ebde770 into openscd:main Jun 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress indicator appears in wrong place if vertical height exceeds window height
2 participants